-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: fix up config links #11254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix up config links #11254
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit a39a32b.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 in general, but with an accessibility note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
PR Checklist
Overview
Affects https://typescript-eslint.io/users/configs
Addresses 2 issues.
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/eslintrc/eslint-recommended.ts is a bad link to use for
eslint-recommended
. It's technically true but doesn't show its contents. So, I've changed it to https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/eslint-recommended-raw.tsThe wording "See
configs/<config-name>.ts
for the exact contents of this config" doesn't really work because those configs are now atconfigs/eslintrc/<config-name>.ts
(with the exception of bullet point 1, which is atconfigs/eslint-recommended-raw.ts
). Since puttingeslintrc
and*-raw
in the link text is IMO distracting, I've opted to change the wording to "Seethe source code for this config
for the exact contents"... Not dead set on this solution, but I'd like to avoid putting the technically-falseconfigs/<config-name>.ts
in the text.