Skip to content

chore(eslint-plugin): [prefer-optional-chain] fix comment placement #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

minor mistake in 3f02687#diff-0930f8c99afdfa35e603494b985d53e7aa8a06eeec2f84df75bebccccba91e40L110

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c7ab47c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6840b8ee0d476400078d41d2
😎 Deploy Preview https://deploy-preview-11269--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 4, 2025

View your CI Pipeline Execution ↗ for commit c7ab47c.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 4s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 12s View ↗
nx run-many -t lint ✅ Succeeded 13s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-04 21:32:20 UTC

@kirkwaiblinger kirkwaiblinger merged commit 0f5c59c into typescript-eslint:main Jun 5, 2025
64 checks passed
@kirkwaiblinger kirkwaiblinger deleted the put-comment-back branch June 5, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants