Skip to content

fix(typescript-estree): add validation to interface extends #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(typescript-estree): add validation to interface extends #11271

wants to merge 3 commits into from
+66 −25

Conversation

ntdiary
Copy link

@ntdiary ntdiary commented Jun 5, 2025 •
edited
Loading

PR Checklist

Overview

The validation logic comes from TypeScript. isPropertyAccessEntityNameExpression and isEntityNameExpression are internal functions from TypeScript, I’ve temporarily placed them above the Converter class, not sure if that’s the good place for them. :)

These are some cases that will throw errors:

// ParenthesizedExpression
interface A extends (typeof fs) { }

// ElementAccessExpression
interface B extends C['D'] { }

// OptionalChain
interface E extends F?.G { }

// multiple extends
interface H extends I extends J { }

// NumericLiteral
interface K extends 2 { }

// nested CallExpression
interface L extends M().N { }

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2332e96
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/684187d2fc179c0008b44c19
😎 Deploy Preview https://deploy-preview-11271--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2332e96.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m View ↗
nx run-many -t typecheck ✅ Succeeded 2m 1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx run-many -t lint ✅ Succeeded 11s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 12:14:47 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (936f350) to head (2332e96).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11271      +/-   ##
==========================================
+ Coverage   90.91%   90.97%   +0.05%     
==========================================
  Files         501      501              
  Lines       50869    50898      +29     
  Branches     8382     8393      +11     
==========================================
+ Hits        46248    46302      +54     
+ Misses       4606     4581      -25     
  Partials       15       15
Flag Coverage Δ
unittest 90.97% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 32.11% <100.00%> (+1.45%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ntdiary
ntdiary commented Jun 5, 2025
View reviewed changes
packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
@@ -360,25 +360,6 @@ export interface Bar extends baz.test {}
code: `
import test from 'test';
import baz from 'baz';
export interface Bar extends baz().test {}
Copy link
Author

@ntdiary ntdiary Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this case is outdated, because TypeScript doesn't allow CallExpression in interface extends. :)

@ntdiary ntdiary marked this pull request as ready for review June 5, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Forbid invalid extend in interface
1 participant
@ntdiary