chore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.ts #11273
Conversation
|
Thanks for the PR, @nayounsang! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit d21ff60.
☁️ Nx Cloud last updated this comment at |
| "false + '';", | ||
| "false + 'text';", | ||
| 'false + true;', | ||
| 'false + false;', |
There was a problem hiding this comment.
'false + true;',
'false + false;',
'true + true;',
'true + false;',In my opinion, it would be neater to leave only one of these.
| "`${__dirname === 'foobar'}`;", | ||
| '`${{}.constructor()}`;', | ||
| '`${() => {}}`;', | ||
| '`${function () {}}`;', | ||
|
|
||
| // operator + += |
There was a problem hiding this comment.
Many of the test cases in the operator + section are essentially duplicates that only differ in operand order. We could consider reducing them by half.
related to this comment: #11273 (comment)
PR Checklist
Overview