Skip to content

fix(typescript-estree): change the token type of null from Keyword to Null #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(typescript-estree): change the token type of null from Keyword to Null #11283

wants to merge 1 commit into from
+29 −37

Conversation

ntdiary
Copy link

@ntdiary ntdiary commented Jun 8, 2025 •
edited
Loading

PR Checklist

Overview

cases:

null;

const a = null;

let b: null;

Feel free to let me know if this need more coverage. :)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 8, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e6d672f
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68454349a251f90008e83b6c
😎 Deploy Preview https://deploy-preview-11283--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e6d672f.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 57s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 55s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 18s View ↗
nx run-many -t lint ✅ Succeeded 11s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded 4s View ↗
nx run generate-configs ✅ Succeeded 10s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-08 08:12:45 UTC

@ntdiary ntdiary changed the title change the token type of null from Keyword to Null fix(typescript-estree): change the token type of null from Keyword to Null Jun 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (1e0ba62) to head (e6d672f).

Files with missing lines Patch % Lines
packages/typescript-estree/src/node-utils.ts 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11283      +/-   ##
==========================================
- Coverage   90.91%   90.91%   -0.01%     
==========================================
  Files         501      501              
  Lines       50869    50872       +3     
  Branches     8382     8383       +1     
==========================================
  Hits        46248    46248              
- Misses       4606     4609       +3     
  Partials       15       15
Flag Coverage Δ
unittest 90.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/node-utils.ts 62.83% <0.00%> (-0.30%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiary ntdiary marked this pull request as ready for review June 8, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The token type of null should be Null instead of Keyword
1 participant
@ntdiary