Fix: koa-views always return the result of the first execution #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e first rendered html
Closed
|
could you deal with it earlier? @jvelo @fabiob @nolazybits @alexproca |
|
same problem |
|
thank you But，The warehouse has not been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first rendering of html, all request results return the first rendered html;
The reason is that
this.koa.use (FN)is called many times, resulting in subsequent requests going through the first registrationFN; The closure variables(renderOptions) ref to the first FN`s renderOptions; Results in the return of the same html.