CLDR-18808 Revise Flagged Items #4993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Revise the table layout and content as proposed in the ticket -Enable downloading as xlsx instead of csv -Modernize with new FlaggedItems.vue; extensively revise cldrFlagged.mjs -Fix formatting of VettingParticipation.vue (minor, should have been done in a previous commit for a different ticket)
-Make the sort key for basic same as for details, that is, locale name + days ago
srl295
approved these changes
Aug 30, 2025
| function addUserInfo(err, args, o) { | ||
| if (err || o.entry.err || !o.entry.user) { | ||
| function storeResponseData(json) { | ||
| // Note: the response json format is no longer very well-suited for how it |
| error: errorHandler, | ||
| }; | ||
| cldrAjax.sendXhr(xhrArgs); | ||
| const FLAGGED_RESPONSE_IS_FAST = true; |
There was a problem hiding this comment.
more common terminology might be sync/asynchronous or blocking/non blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Revise the table layout and content as proposed in the ticket
-Enable downloading as xlsx instead of csv
-Modernize with new FlaggedItems.vue; extensively revise cldrFlagged.mjs
-Fix formatting of VettingParticipation.vue (minor, should have been done in a previous commit for a different ticket)
CLDR-18808
ALLOW_MANY_COMMITS=true