End-to-End Categorized Units Formatter with sliced data (Core / Extended / Outlier) #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `preferences` module in `cldr_serde/units` for handling unit preferences. - Added `unitPreferenceData.json` file to the test data, containing structured unit preference information. - Updated relevant modules to include the new `preferences` module and its functionality. - Enhanced `SourceDataProvider` to include unit preference data in the test setup.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
- Introduced various new JSON files for unit lengths (e.g., centimeter, foot, mile) across multiple languages. - Added new modules for categorized display names and updated existing modules to include these new data structures. - Enhanced the `SourceDataProvider` to support the new unit length data and ensure proper integration with existing functionality.
- Introduced new JSON files for various units of length and mass (e.g., long-meter, short-kilogram) across multiple languages. - Removed outdated JSON files for certain units (e.g., long-foot, narrow-pound) to streamline the dataset. - Updated related modules to ensure compatibility with the new data structures and maintain functionality.
- Introduced new JSON files for volume units (e.g., core, extended, outlier) across multiple languages. - Updated the `categorized_display_name` module to include new volume unit display names. - Enhanced the `SourceDataProvider` to support the new volume unit data and ensure proper integration with existing functionality.
…unit markers - Updated the `CategorizedFormatter` to utilize separate data markers for core, extended, and outlier units. - Introduced new methods for creating formatters with extended and outlier data. - Enhanced the `MeasureUnitCategory` trait to define additional data markers for each unit category. - Updated tests to validate the new formatter functionality across different locales and unit types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements an end-to-end “categorized units” formatter that slices units data into Core, Extended, and Outlier tiers, and wires that slicing through data loading, markers, and formatter construction. It also introduces unit preferences plumbing.
FOLLOW-UP ISSUE #6900
What’s included
cldr_serde/unitsto handle unit preference data.unitPreferenceData.jsonadded to exercise preference-aware paths.CategorizedFormatternow supports separate data markers for Core, Extended, and Outlier; added constructors to opt into Extended and Outlier.MeasureUnitCategoryextended to define additional data markers per category.