Add Easter holiday to Gregorian and Julian
#6899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregorian and JulianGregorian and Julian
sffc
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
I approve because:
- Calculating the date of Easter is a calendrical calculation, not simply a fixed date or "first Monday of the month", so it is something useful for our calendar types to offer
- There are secular use cases for Easter since many countries, especially in Europe, have federal holidays that are derived from the date of Easter
Comment on lines
+211
to
+215
|
|
||
| /// Returns the date of (Orthodox) Easter in the given year. | ||
| pub fn easter(year: i32) -> Date<Self> { | ||
| Date::from_rata_die(calendrical_calculations::julian::easter(year), Self) | ||
| } |
There was a problem hiding this comment.
Thought: Should this go in the Coptic calendar, too?
There was a problem hiding this comment.
Those two calendars are close enough to the Julian calendar that they use the dates as calculated by the Julian calendar: https://en.wikipedia.org/wiki/Coptic_calendar#Easter. So they should be constructed like Julian::easter(y).to_calendar(Coptic/Ethiopian).
In fact, the only use case I see for Julian::easter is Julian::easter(y).to_calendar(c), as no country actually uses the Julian calendar, and it's not in AnyCalendar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hijri calendars are basically exclusively religious, so we have precedent for something like this.