Skip to content

Publish zoneinfo64 and resb as 0.1.0 #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

Publish zoneinfo64 and resb as 0.1.0 #6901

merged 3 commits into from
Aug 28, 2025

Conversation

Manishearth
Copy link
Member

We can start using these in temporal_rs.

@Manishearth Manishearth requested a review from a team as a code owner August 26, 2025 19:05
@gemini-code-assist Gemini Code Assist
Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@Manishearth Manishearth requested a review from sffc August 26, 2025 19:08
@Manishearth Manishearth mentioned this pull request Aug 26, 2025
Closed
robertbastian
robertbastian reviewed Aug 26, 2025
View reviewed changes
robertbastian
robertbastian previously approved these changes Aug 26, 2025
View reviewed changes
sffc
sffc previously approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support 0.1 releases if the authors feel there is enough feature coverage to make the crate useful

@Manishearth
Copy link
Member Author

I think I'd like #6902 to land first before releasing.

@Manishearth Manishearth dismissed stale reviews from sffc and robertbastian via e16bdbd August 28, 2025 19:39
@Manishearth Manishearth merged commit 7d369fb into unicode-org:main Aug 28, 2025
31 of 32 checks passed
@Manishearth Manishearth deleted the zoneinfo64 branch August 28, 2025 20:03
@Manishearth
Copy link
Member Author

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @sffc @robertbastian