Reduce the size of Zone by deferring lookups
#6903
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
bced31e to
b3c26a6
Compare
|
Meeting minutes: #6902 (comment) |
Alternative to #6902
This defers the lookups in
zones,names,rules, andregionsfrom the constructor, only storing the index in theZonestruct.This will cost an additional lookup at the beginning of each zone operation, but these are fairly lookup-heavy already anyway. It also saves the lookups for name and region, which are probably only needed very rarely. In exchange, the size of
Zonegets significantly decreased.Also adds a
RawZoneabstraction which can be GIGO converted to and fromZone, with the invariant being that the sameZoneInfo64instance is used throughout. Users like temporal can combine this with a staticLazyLock<ZoneInfo64>to provide a safe wrapper with minimal size.