Add Rust types to encode the trie type in the Rust type #6906
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
I've spent way too much time trying to make the branches whose optimization brittleness I added comments about to do the right thing. It's not particularly worthwhile to put more effort into that before further changes to the normalizer, since pretty much anything can disturb how those compile, so it makes sense to do the other changes first. |
|
I removed the new external dependency and instead imported |
|
|
||
| /// Holder for either fast or small trie with the trie | ||
| /// type encoded into the Rust type. | ||
| pub enum Typed<F, S> { |
There was a problem hiding this comment.
nit: @sffc thoughts about the name? Typed isn't bad but there may be other ones that are better.
FastOrSmall?
| @@ -65,13 +65,13 @@ utf8_iter = ["dep:utf8_iter"] | |||
| # behind `not(serde)` instead. See a comment in `lib.rs` for | |||
| # the TODO list explaining why the relevant bits aren't | |||
| # already behind `not(serde)` instead. | |||
| # unstable_fast_trie_only = [] | |||
| # icu4x_unstable_fast_trie_only = [] | |||
There was a problem hiding this comment.
nit: we're not using this feature anymore, just the cfg
Fixes #5796