Skip to content

Conversation

Manishearth
Copy link
Member

We need these for the latest zoneinfo64

@Manishearth Manishearth requested a review from a team as a code owner August 28, 2025 20:42
@Manishearth Manishearth requested a review from sffc August 28, 2025 20:42
Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@robertbastian
Copy link
Member

also bump icu_calendar to 2.0.4 here while you're at it

CHANGELOG.md Outdated
@@ -41,6 +42,9 @@ Several crates have had patch releases in the 2.0 stream:
- (2.0.1) Update to tzdb 2025b
- `calendrical_calculations`
- (0.2.1) Fix a sign error in `RataDie::until`, add `RataDie::since` (unicode-org#6861)
- (0.2.2) Make `iso_year_from_fixed`, `day_before_year` public (unicode-org#6871)
- (0.2.2) Optimise `day_of_provided_year`, `date_from_provided_year_day` for ISO/Gregorian (unicode-org#6883)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are icu_calendar API names. maybe just say optimise some calculations in iso

Manishearth and others added 2 commits August 28, 2025 13:56
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
@Manishearth Manishearth merged commit fbb3eeb into unicode-org:main Aug 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants