Skip to content

Add a failing test for json import in js file #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a failing test for json import in js file #173

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented May 19, 2025

Description

Importing json files from js fails to parse.

Linked Issues

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

orgads
orgads commented May 19, 2025
View reviewed changes
test/index.test.ts
plugins: [
swc.rollup(),
],
})).rejects.toThrow(' x Expected \';\', got \'with\'')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to resolves of course.

@orgads
Copy link
Contributor Author

orgads commented May 19, 2025

Setting importAttributes: true, in jsc.parser solves this. Does it make sense to add an option for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orgads