refactor: dynamic row height calcualtion for correct wrapping and pr… #9
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @utkuakyuz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the diff viewer component to dynamically calculate row heights, addressing visual issues where long text content would overlap due to incorrect wrapping. By introducing a new method for height calculation based on wrapped lines and adjusting related CSS, the viewer now correctly manages text overflow, ensuring a more accurate and visually consistent display of diffs.
Highlights
- Dynamic Row Height Calculation: Implemented a new state rowHeights and a measureRows function in VirtualizedDiffViewer.tsx to compute and store the height for each row based on its wrapped content.
- Improved getItemSize Logic: The getItemSize function now leverages the dynamically calculated rowHeights to provide accurate dimensions for virtualized list rows, accommodating multi-line text.
- CSS Enhancements for Text Wrapping: Updated JsonDiffCustomTheme.css to apply white-space: pre-wrap, word-break: break-all, and other properties to pre elements, ensuring proper text wrapping within diff lines.
- Responsive Height Adjustment: Added event listeners to re-measure row heights on window resize, ensuring the diff viewer remains responsive and visually correct across different screen sizes.
- Utility for Wrap Count: Introduced a getWrapCount helper function to precisely determine the number of lines an element's content occupies, aiding in accurate height calculations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for virtual-react-json-diff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic row height calculation to handle text wrapping, which is a great improvement for displaying long text values. The implementation is solid, but I have a few suggestions to improve its robustness and maintainability.
My main points are:
- Scoping DOM queries to the component instance to prevent bugs when multiple viewers are present.
- Using
useLayoutEffectfor DOM measurements to avoid race conditions. - Improving the
getWrapCountutility function. - Decoupling the hardcoded
line-heightin CSS from theROW_HEIGHTconstant in JavaScript.
These changes will make the component more reliable and easier to maintain in the future.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Closes #8 |
This PR introduces a new method of row height calculation to correctly manage wrapped rows.
Some texts could be longer than the row width, in that case overlapping was not correctly working and causing visual issues.
Correcting the CSS and dynamically calculating height of virtual rows while observing the wrapped row count will resolve the issue.
See issue #8