Skip to content

l10n: add support for clap translations #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 13, 2025
Merged

l10n: add support for clap translations #8431

merged 17 commits into from
Aug 13, 2025

Conversation

sylvestre
Copy link
Contributor

No description provided.

@sylvestre sylvestre marked this pull request as ready for review August 4, 2025 22:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

GNU testsuite comparison:

GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/comm. tests/misc/comm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/diag. tests/mv/diag is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/mv-exchange. tests/mv/mv-exchange is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

drinkcat
drinkcat reviewed Aug 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 5, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 5, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2025

GNU testsuite comparison:

GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/comm. tests/misc/comm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/diag. tests/mv/diag is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/mv-exchange. tests/mv/mv-exchange is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Aug 5, 2025
View reviewed changes
@sylvestre sylvestre force-pushed the clap-loca branch 3 times, most recently from 9aa20ea to 93cbb31 Compare August 9, 2025 16:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/comm. tests/misc/comm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/diag. tests/mv/diag is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/mv-exchange. tests/mv/mv-exchange is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025

GNU testsuite comparison:

GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/comm. tests/misc/comm is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/mv-exchange. tests/mv/mv-exchange is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@cakebaker
Copy link
Contributor

Somehow you have added many unrelated commits to the PR :|

@sylvestre sylvestre marked this pull request as draft August 10, 2025 11:38
@sylvestre
Copy link
Contributor Author

oh crap
anyway, i am working on it

i fixed the gnu issue

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre marked this pull request as ready for review August 11, 2025 22:00
@sylvestre sylvestre force-pushed the clap-loca branch 2 times, most recently from 6e873ba to 69918c7 Compare August 12, 2025 08:20
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
tests/by-util/test_ls.rs Outdated
Comment on lines 91 to 92
.env("LANG", "en_US.UTF-8")
.env("LC_ALL", "en_US.UTF-8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Shouldn't there be a loop over the env vars? Something like:

for key in ["LANG", "LC_ALL"] {
    new_ucmd!()
        .env(key, "en_US.UTF-8")
        ...
}

cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
cakebaker
cakebaker reviewed Aug 12, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

1 similar comment
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

sylvestre added 15 commits August 13, 2025 14:15
@sylvestre
l10n: Add LocalizedCommand trait for clap localization
e674fb9
@sylvestre
l10n: Migrate all utilities to use LocalizedCommand
b754c67
@sylvestre
l10n/github action: verify that clap localization works
8767cfd
@sylvestre
add test (in sort) to verify that the clap error mgmt work (english a…
0881b6e 
…nd french)
@sylvestre
cspell: also ignore flt files in uucore
19aa5f8
@sylvestre
l10n: also install uucore locales
90b4fd7
@sylvestre
clap localization: address PR review comments
d76a8d1 
  - Make colorize() function private since only used internally
  - Remove redundant colors_enabled checks
  - Add apply_color helper closure to reduce code duplication
  - Remove try_ prefix from function names for consistency
  - Update all utilities to use renamed functions
  - Fix app variable reference in mv utility
@sylvestre
clap: override the usage section
f0290e4
@sylvestre
clap: improve the clap support + add tests
4514bf0
@sylvestre
Port printenv translation: fix tests/misc/invalid-opt
4b87d5a
@sylvestre
Port factor for translation
37c633e
@sylvestre
clap: improve translation support
096cab0
@sylvestre
allow translation of "For more information, try '--help'."
e8dccfc
@sylvestre
clap: translate Usage too
023c570
@sylvestre
clap: also support translations for invalid values
6a9e32f
@sylvestre
Copy link
Contributor Author

@cakebaker should be good this time, thanks for the great review!

@cakebaker
Copy link
Contributor

@sylvestre clippy is not happy yet ;-)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor Author

@sylvestre clippy is not happy yet ;-)

fixed! :)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 4af2a84 into uutils:main Aug 13, 2025
91 checks passed
@cakebaker
Copy link
Contributor

Good work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

@drinkcat drinkcat drinkcat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sylvestre @cakebaker @drinkcat