chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature #13437

PengBoUESTC · 2025-06-05T05:38:51Z

processFor Ts type opt
remove condenseWhitespace tag param

Summary by CodeRabbit

Refactor
- Updated internal function signatures to improve clarity and consistency. No changes to user-facing features or behavior.

coderabbitai · 2025-06-05T05:39:00Z

Walkthrough

The updates modify function signatures in two files. The condenseWhitespace function in the parser removes its optional tag parameter from both definition and usage. The processFor function in the vFor transform now explicitly declares its return type as (() => void) | undefined, clarifying its output.

Changes

File(s)	Change Summary
parser.ts	Removed the optional `tag` parameter from `condenseWhitespace`'s signature and all calls.
transforms/vFor.ts	Added explicit return type `(() => void)

Poem

A hop and a skip through the code we go,
Trimming a tag where whitespace did flow.
Now processFor tells what it will yield—
A void or a cleanup, its intent revealed.
With signatures neat, the garden’s in bloom,
CodeRabbit’s joy echoes through the room! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95d7189 and fe1333f.

📒 Files selected for processing (1)

packages/compiler-core/src/transforms/vFor.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/compiler-core/src/transforms/vFor.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed
GitHub Check: test / e2e-test
GitHub Check: test / unit-test-windows

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-05T05:39:55Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.4 kB	34.6 kB
vue.global.prod.js	159 kB (-2 B)	58.5 kB (-8 B)	52.2 kB (+23 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.7 kB	18.2 kB	16.7 kB
createApp	54.6 kB	21.3 kB	19.4 kB
createSSRApp	58.9 kB	23 kB	21 kB
defineCustomElement	59.6 kB	22.9 kB	20.9 kB
overall	68.7 kB	26.4 kB	24.1 kB

pkg-pr-new · 2025-06-05T05:40:04Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13437

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13437

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13437

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13437

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13437

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13437

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13437

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13437

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13437

vue

npm i https://pkg.pr.new/vue@13437

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13437

commit: fe1333f

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/compiler-core/src/transforms/vFor.ts (1)
266-266: Improve type clarity by using undefined instead of void.

The explicit return type annotation is a good improvement for clarity. However, consider using undefined instead of void in the union type for better clarity.

Apply this diff to improve type clarity:
-): void | (() => void) {
+): undefined | (() => void) {
This follows the static analysis recommendation and makes the union type more explicit about what the function can return.

🧰 Tools

🪛 Biome (1.9.4)

[error] 266-266: void is confusing inside a union type.

Unsafe fix: Use undefined instead.

(lint/suspicious/noConfusingVoidType)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a47832e and 8608cf4.

📒 Files selected for processing (2)

packages/compiler-core/src/parser.ts (2 hunks)
packages/compiler-core/src/transforms/vFor.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/compiler-core/src/parser.ts (1)

packages/compiler-core/src/ast.ts (1)

TemplateChildNode (93-102)

🪛 Biome (1.9.4)

packages/compiler-core/src/transforms/vFor.ts

[error] 266-266: void is confusing inside a union type.

Unsafe fix: Use undefined instead.

(lint/suspicious/noConfusingVoidType)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Redirect rules
GitHub Check: test / e2e-test
GitHub Check: test / unit-test-windows
GitHub Check: Header rules
GitHub Check: Pages changed

🔇 Additional comments (2)

packages/compiler-core/src/parser.ts (2)

650-650: LGTM: Function call updated correctly.

The removal of the tag parameter from the condenseWhitespace call is consistent with the function signature change.

835-835: Good cleanup: Removed unused parameter.

The tag parameter was not being used in the function implementation, so removing it improves the function signature clarity and eliminates unnecessary parameters.

chore: processFor Ts type opt & remove condenseWhitespace params

8608cf4

coderabbitai bot reviewed Jun 5, 2025

View reviewed changes

chore: minor tweaks

fe1333f

edison1105 force-pushed the chore/code-opt branch from 95d7189 to fe1333f Compare June 6, 2025 00:21

edison1105 changed the title ~~chore: processFor Ts type opt & remove condenseWhitespace params~~ chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature Jun 6, 2025

edison1105 merged commit cdffaf6 into vuejs:main Jun 6, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature #13437

chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature #13437

Uh oh!

PengBoUESTC commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature #13437

chore(compile-core): removed the optional tag parameter from condenseWhitespace's signature #13437

Uh oh!

Conversation

PengBoUESTC commented Jun 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PengBoUESTC commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 5, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 5, 2025 •

edited

Loading