perf(compiler): remove regx for removeStaticBinding #13445

Plumbiu · 2025-06-08T03:06:47Z

Regular expression new RegExp(`^ ${binding}=".+"$`) is easily replaced using string methods.

For example, the binding is 'class'

Tag item must startsWith class=" and endsWith "
The length of the tag must be greater than or equal to 10 ( class=" + " + At least one character)

Benchmark shows 1.92x faster than before.

 ✓ index.bench.ts 2840ms
     name                           hz     min     max    mean     p75     p99    p995    p999     rme  samples
   · pr                   2,690,971.89  0.0000  1.1450  0.0004  0.0000  0.0050  0.0050  0.0050  ±1.15%  1345486
   · removeStaticBinding  1,404,261.72  0.0000  9.7050  0.0007  0.0000  0.0050  0.0050  0.0150  ±5.01%   702131

 BENCH  Summary

  pr - index.bench.ts
    1.92x faster than removeStaticBinding

Summary by CodeRabbit

Refactor
- Improved the method for identifying and removing static bindings, enhancing reliability and maintainability. No changes to user-facing features.

coderabbitai · 2025-06-08T03:06:55Z

Walkthrough

The removeStaticBinding function in the SSR compiler transform was updated to use explicit string checks instead of a regular expression for identifying and removing static bindings from a template literal array. The update also introduces a type check to ensure the element is a string before processing.

Changes

File(s)	Change Summary
packages/compiler-ssr/src/transforms/ssrTransformElement.ts	Replaced regex-based static binding search with explicit string checks and added a type check.

Poem

In the garden of code, regex took flight,
Replaced by string checks, simple and light.
With careful type checks, the bugs hop away,
The compiler now smiles, ready to play.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdffaf6 and d9a88fe.

📒 Files selected for processing (1)

packages/compiler-ssr/src/transforms/ssrTransformElement.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/compiler-ssr/src/transforms/ssrTransformElement.ts (1)

packages/shared/src/general.ts (1)

isString (51-51)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed
GitHub Check: test / e2e-test
GitHub Check: test / unit-test-windows

🔇 Additional comments (2)

packages/compiler-ssr/src/transforms/ssrTransformElement.ts (2)

42-42: Good addition for type safety.

The isString import is appropriately added to support the type guard in the refactored function.

427-441: Excellent performance optimization with maintained correctness.

The string-based approach effectively replaces the regex while preserving the exact matching logic:

bindingStart constructs the prefix pattern

minLen ensures at least one character exists between quotes

The findIndex conditions are equivalent to the original regex ^ ${binding}=".+"$

Type guard with isString adds safety for the heterogeneous array

This implementation should provide the claimed ~2x performance improvement while handling all edge cases correctly, including empty attribute values like class="".

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-08T03:07:52Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.4 kB	34.6 kB
vue.global.prod.js	159 kB	58.5 kB	52.2 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.7 kB	18.2 kB	16.7 kB
createApp	54.6 kB	21.3 kB	19.4 kB
createSSRApp	58.9 kB	23 kB	21 kB
defineCustomElement	59.6 kB	22.9 kB	20.9 kB
overall	68.7 kB	26.4 kB	24.1 kB

pkg-pr-new · 2025-06-08T03:07:57Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13445

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13445

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13445

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13445

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13445

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13445

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13445

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13445

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13445

vue

npm i https://pkg.pr.new/vue@13445

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13445

commit: d9a88fe

edison1105 · 2025-06-10T09:08:25Z

packages/compiler-ssr/src/transforms/ssrTransformElement.ts

+  // tag must end with at least one character and "
+  const minLen = bindingStart.length + 2
+  const i = tag.findIndex(
+    e =>


const i = tag.findIndex(e => { if (!isString(e)) return false const l = e.length return l >= minLen && e[0] === bindingStart && e[l - 1] === '"' })

I think this one should be faster

Edit:
see https://stackblitz.com/edit/vitest-dev-vitest-6vkzwb1g?file=index.ts

perf(compiler): remove regx for removeStaticBinding

d9a88fe

edison1105 reviewed Jun 10, 2025

View reviewed changes

edison1105 added 🧹 p1-chore Priority 1: this doesn't change code behavior. wait changes labels Jun 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(compiler): remove regx for removeStaticBinding #13445

perf(compiler): remove regx for removeStaticBinding #13445

Plumbiu commented Jun 8, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 8, 2025

Uh oh!

pkg-pr-new bot commented Jun 8, 2025

Uh oh!

edison1105 Jun 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

perf(compiler): remove regx for removeStaticBinding #13445

Are you sure you want to change the base?

perf(compiler): remove regx for removeStaticBinding #13445

Conversation

Plumbiu commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 8, 2025

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Jun 8, 2025

Uh oh!

edison1105 Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Plumbiu commented Jun 8, 2025 •

edited

Loading

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

edison1105 Jun 10, 2025 •

edited

Loading