fix(runtime-core): avoid setting direct ref of useTemplateRef in dev #13449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes add conditional logic to the template ref assignment mechanism, introducing a helper that prevents setting Changes
Sequence Diagram(s)sequenceDiagram
participant Component
participant Renderer
participant RefHelper
Component->>Renderer: Render element with useTemplateRef (direct ref, ref_key)
Renderer->>RefHelper: canSetRef(ref)
alt canSetRef = true
RefHelper-->>Renderer: true
Renderer->>Ref: Set ref.value to element
else canSetRef = false
RefHelper-->>Renderer: false
Renderer-->>Ref: Skip setting ref.value
end
Renderer->>Component: Complete render, refs updated
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
alex-snezhko
commented
Jun 8, 2025
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
edison1105
reviewed
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid directly setting the ref value in dev mode whenever a ref object from a
useTemplateRefcall is used for rendering, updating only the component owner refs object instead (whichuseTemplateRefis hooked up to correctly update from).When code like the following:
is compiled in inline mode the output would contain:
which then attempts to update the
myRefobject directly, showing a warning:Set operation on key "value" failed: target is readonly.; this change should avoid this warning from showing.closes #12852
Summary by CodeRabbit
Tests
Bug Fixes