Skip to content

test(runtime-core): remove incorrect suspense test in vnode spec #13782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

test(runtime-core): remove incorrect suspense test in vnode spec #13782

merged 1 commit into from
Aug 20, 2025
+0 −12

Conversation

alentide
Copy link
Contributor

@alentide alentide commented Aug 20, 2025 •
edited by coderabbitai bot
Loading

The test case for 'suspense' was misleading as its implementation was a copy of the functional component test. It is removed because the core logic for block tracking in createBaseVNode only explicitly checks for COMPONENT shape flags. Testing every non-component type is unnecessary. Removing this test improves the clarity and focus of the spec.

Summary by CodeRabbit

  • Tests
    • Removed a test case related to suspense and dynamic children to improve test suite stability and reduce false negatives.
    • Clarified expectations by eliminating a brittle scenario that no longer reflects current behavior.
    • No changes to runtime behavior, features, performance, or public APIs.
    • End users will see no functional differences; this is a maintenance-focused update.

@alentide
test(runtime-core): remove incorrect suspense test in vnode spec
36fcb23 
The test case for 'suspense' was misleading as its implementation was a copy of the functional component test. It is removed because the core logic for block tracking in createBaseVNode only explicitly checks for COMPONENT shape flags. Testing every non-component type is unnecessary. Removing this test improves the clarity and focus of the spec.
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025 •
edited
Loading

Walkthrough

Removed a single test case ("with suspense") from packages/runtime-core/tests/vnode.spec.ts. No production code or public API changes.

Changes

Cohort / File(s) Summary of Changes
Test cleanup
packages/runtime-core/__tests__/vnode.spec.ts		 Deleted the "with suspense" test that asserted dynamicChildren behavior for a Block vnode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ready to merge

Poem

A whisk of code, a hop so light,
One test departs into the night.
Carrots counted, specs still neat—
Fewer checks, the build’s complete.
Thump-thump! I merge with gentle cheer,
Clean burrow now, no bugs to fear. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c875019 and 36fcb23.

📒 Files selected for processing (1)
  • packages/runtime-core/__tests__/vnode.spec.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/runtime-core/tests/vnode.spec.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edison1105 edison1105 merged commit 8963b79 into vuejs:main Aug 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alentide @edison1105