Skip to content

Conversation

zhiyuanzmj
Copy link
Member

@zhiyuanzmj zhiyuanzmj commented Aug 30, 2025

  1. defineVaporComponent types.
  • Functional defineVaporComponent
import { computed, type ComputedRef, type Block } from 'vue'

const Comp = defineVaporComponent(
    <T extends number>(
      props: { foo: T },
      {
        expose,
        slots,
      }: {
        slots: { default?: (props: { foo: T }) => Block }
        expose: (exposed: { double: ComputedRef<T> }) => void
      },
    ) => {
      const double = computed(() => (props.foo * 2) as T)
      expose({ double })
      return slots.default!({ foo: props.foo })
    },
)

const comp = new Comp<1>({ foo: 1 })
comp.props.foo === ({} as 1)
comp.exposeProxy?.double === ({} as 1)
comp.slots === ({} as { default?: (props: { foo: 1 }) => Block })
  • Optional defineVaporComponent
const Comp = defineVaporComponent({
  props: {
    foo: {
      type: Number,
      required: true,
    }
  },
  slots: {} as { default?: (props: { foo: number }) => Block }
  setup(props){
    const double = computed(() => props.foo * 2)
    return {
      double
    }
  },
  render(ctx, props, emit, attrs, slots){
    return slots.default?.({ foo: props.foo })
  }
})

const comp = new Comp({ foo: 1 })
comp.props.foo === {} as number
comp.exposeProxy?.double === {} as number
comp.slots === ({} as { default?: (props: { foo: number }) => Block })
  1. Remove JSX.ElementAttributesProperty and JSX.ElementClass to enable Vapor and VDom co-usage.
// jsx.d.ts
declare global {
  namespace JSX {
    export type Element = VNode | Block
  }
}

Using the constructor's first parameter as JSX props instead.

interface Constructor<P = any> {
  new (props?: P): { $props: P }
  //   ^^^^^^^^^
}

Copy link

coderabbitai bot commented Aug 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.7 kB (+123 B) 25.9 kB (+54 B) 23.7 kB (+78 B)
createVaporApp 21 kB (+123 B) 8.31 kB (+51 B) 7.62 kB (+51 B)
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

pkg-pr-new bot commented Aug 30, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13831

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13831

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13831

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13831

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13831

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13831

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13831

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13831

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13831

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13831

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13831

vue

npm i https://pkg.pr.new/vue@13831

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13831

commit: bd21aee

Copy link

netlify bot commented Aug 30, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit bd21aee
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68bcee929653bc0008d5c16f

@zhiyuanzmj zhiyuanzmj added the scope: vapor related to vapor mode label Aug 31, 2025
@zhiyuanzmj zhiyuanzmj changed the title feat(vapor): implement defineVaporComponent types feat(runtime-vapor): implement defineVaporComponent types Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: vapor related to vapor mode version: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants