someone who understands filters more should confirm im not talking nonsense

but i wonder if its better this be implemented as some kind of event filter, such that it never reaches commit (similar to how you can probably do that now via the eventFilter option)

if it turns out that's a silly idea - this PR does look good meanwhile, although i'd be tempted to call it something like shouldCommit since its specifically to check if it should commit, rather than being a plain hook

edit:

basically a filter like this:

function equalityFilter<T>(val: Ref<T>, isEqual: (oldValue: T, newValue: T) => boolean): EventFilter {
     const lastValue = ref(val.value)

     return (invoke) => {
       if (!isEqual(lastValue.value, val.value))
         lastValue.value = val.value
         invoke()
       }
    }
   }

but yeah i could just be overcomplicating things 🤷

someone who understands filters more should confirm im not talking nonsense

but i wonder if its better this be implemented as some kind of event filter, such that it never reaches commit (similar to how you can probably do that now via the eventFilter option)

if it turns out that's a silly idea - this PR does look good meanwhile, although i'd be tempted to call it something like shouldCommit since its specifically to check if it should commit, rather than being a plain hook

edit:

basically a filter like this:

function equalityFilter<T>(val: Ref<T>, isEqual: (oldValue: T, newValue: T) => boolean): EventFilter {
     const lastValue = ref(val.value)

     return (invoke) => {
       if (!isEqual(lastValue.value, val.value))
         lastValue.value = val.value
         invoke()
       }
    }
   }

but yeah i could just be overcomplicating things 🤷

ShouldCommit is a more appropriate name, beforeCommit is more like a hook.
eventFilter currently does not support multiple scenarios. If equalityFilter is used, debounceFilter will fail again. This should be a broader scenario and a heavier workload. I think this design is the best. Just consider whether you really need to add multiple to eventFilter.

Looks good so far. Maybe you can add tests to prevent future regressions. 👍🏽

Looks good so far. Maybe you can add tests to prevent future regressions. 👍🏽

Added :)