chore(computedEager): mark for deprecation #4748
Conversation
|
LGTM. Maybe we can just alias it too 🤔 I think |
|
@OrbisK You mean to remove the code (alongside the deprecation marking) and then in next major remove the aliasing as well? Or keep the aliasing indifinitely? |
Mark deprecated, and alias (if possible). Remove at some major. |
|
Why did we remove the tests? And if we deprecate a function, we should provide the reason and way to migrate in the docs and the jsdoc. "This function will be removed in future version" is confusing to have the next action even for me. |
|
@antfu I removed the tests because I assume that functionality is now tested on Vue core, so it doesn't make sense to maintain our own suite of tests (specially if we are going to remove the entire source code of this function in a future major). Reintroduced the tests for now (they can always be removed later, when the composable is effectively removed from our source code). I also thought the JSDoc message above explaining that Vue 3.4's computed worked exactly the same as computedEager was enough, but added it explicitly. |
Before submitting the PR, please make sure you do the following
fixes #123).Description
Marks this composable as deprecated so it can be removed in a future major version.
Additional context
In my opinion, there is no reason users can't always track latest minor Vue releases. It's been a while since Vue 3.4 has been released and Vue 3.6 is around the corner, so there have been plenty of time for every person to test their
computedEagerusages (plus the introduction in Vue in normalcomputedhas hardly been breaking).Users that stil want to lag behind Vue updates won't also have a problem staying behind in VueUse's