perf(useTemplateRefsList): Optimize with shallowRef #4802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrbisK
reviewed
Jun 7, 2025
| export function useTemplateRefsList<T = Element>(): Readonly<Ref<Readonly<TemplateRefsList<T>>>> { | ||
| const refs = deepRef<unknown>([]) as Ref<TemplateRefsList<T>> | ||
| export function useTemplateRefsList<T = Element>(): Readonly<ShallowRef<Readonly<TemplateRefsList<T>>>> { | ||
| const refs = shallowRef<unknown>([]) as ShallowRef<TemplateRefsList<T>> |
There was a problem hiding this comment.
do we still need that cast?
Suggested change
| const refs = shallowRef<unknown>([]) as ShallowRef<TemplateRefsList<T>> | |
| const refs = shallowRef<TemplateRefsList<T>>([]) |
There was a problem hiding this comment.
Unfortunately, it seems so :(
There was a problem hiding this comment.
Because [] doesn't have a set method?
So the type checker is right to raise that
You could instead create the empty array first, cast it and add the set method onto it
Then pass that in and get rid of line 10
OrbisK
reviewed
Jun 11, 2025
| export function useTemplateRefsList<T = Element>(): Readonly<Ref<Readonly<TemplateRefsList<T>>>> { | ||
| const refs = deepRef<unknown>([]) as Ref<TemplateRefsList<T>> | ||
| export function useTemplateRefsList<T = Element>(): Readonly<ShallowRef<Readonly<TemplateRefsList<T>>>> { | ||
| const refs = shallowRef<unknown>([]) as ShallowRef<TemplateRefsList<T>> | ||
| refs.value.set = (el: object | null) => { |
There was a problem hiding this comment.
if we use shallow ref does this trigger the ref?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR optimizes
useTemplateRefsListperformance by switching toshallowRefto avoid unnecessary deep reactivity.