Skip to content

pr：(watchIgnorable): #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pr：(watchIgnorable): #4808

wants to merge 1 commit into from

Conversation

licong325
Copy link

@licong325 licong325 commented Jun 9, 2025 •
edited
Loading

  • 改进 ignoreUpdates 异常处理

  • 同步模式下使用 try/finally 确保标志重置

  • 修复 flush 选项的 TypeScript 类型错误

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Additional context

@licong325
pr：(watchIgnorable):
237aa48 
- 改进 ignoreUpdates 异常处理

- 同步模式下使用 try/finally 确保标志重置
- 修复 flush 选项的 TypeScript 类型错误
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 9, 2025
OrbisK
OrbisK reviewed Jun 10, 2025
View reviewed changes
packages/shared/watchIgnorable/index.ts
@@ -39,7 +40,7 @@ export function watchIgnorable<Immediate extends Readonly<boolean> = false>(
let ignorePrevAsyncUpdates: () => void
let stop: () => void

if (watchOptions.flush === 'sync') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? this is breaking

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It's that I don't understand thoroughly enough. I will close this application

@licong325 licong325 closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK left review comments

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@licong325 @OrbisK