Skip to content

fix(useFileDialog): fixing issue where custom input passed in was too eager with later initialized template refs #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(useFileDialog): fixing issue where custom input passed in was too eager with later initialized template refs #4868

wants to merge 1 commit into from

Conversation

rory-instil
Copy link

@rory-instil rory-instil commented Jul 9, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

Fixes #4867

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 9, 2025
@hunterwilhelm
Copy link
Contributor

+1 Although closely related, this PR addresses an improvement that my PR #4813 doesn't. Both are needed.

@rory-instil rory-instil force-pushed the rarmstrongfeat/use-file-dialog-custom-input-ref branch from c12fa19 to d26ebf2 Compare July 11, 2025 08:54
@VividLemon

This comment was marked as duplicate.

Sign in to view
@OrbisK
Copy link
Collaborator

OrbisK commented Jul 29, 2025

@rory-instil can you rebase your pr and resolve the conflicts?

@rory-instil rory-instil force-pushed the rarmstrongfeat/use-file-dialog-custom-input-ref branch 3 times, most recently from c1c9429 to f7e7eb6 Compare July 29, 2025 16:08
@rory-instil rory-instil force-pushed the rarmstrongfeat/use-file-dialog-custom-input-ref branch from f7e7eb6 to 15371b6 Compare July 31, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useFileDialog | Make custom input less eager for late initilised template refs
4 participants
@rory-instil @hunterwilhelm @VividLemon @OrbisK