feat(useAsyncState): cancel previous promise and use latest promise #4936
Conversation
@vueuse/components
@vueuse/core
@vueuse/electron
@vueuse/firebase
@vueuse/integrations
@vueuse/math
@vueuse/metadata
@vueuse/nuxt
@vueuse/router
@vueuse/rxjs
@vueuse/shared
commit: |
| const rawPromise = _promise | ||
| _promise = new Promise((resolve, reject) => { | ||
| cancel() | ||
| cancel = () => (resolve = reject = noop) |
There was a problem hiding this comment.
But this doesn't actually cancel the previous promise; it still continues executing in the background, right?
There was a problem hiding this comment.
But this doesn't actually cancel the previous promise; it still continues executing in the background, right?
Thanks for the review 🙏 — you're totally right, the previous promise isn't truly cancelled; it still runs in the background.
What the code does is invalidate the resolve and reject of the previous promise whenever execute is called, so that only the latest one takes effect.
This way, we avoid having any result from the old promise interfere with the new one
There was a problem hiding this comment.
Maybe you could look into AbortController
There was a problem hiding this comment.
We can wait for nuxt/nuxt#32531 and adapt some changes
There was a problem hiding this comment.
Maybe you could look into AbortController
Got it, thanks！
There was a problem hiding this comment.
We can wait for nuxt/nuxt#32531 and adapt some changes
I see see. Thanks for the reply
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR fixes an issue where, due to network delays, older requests could overwrite the latest one — like when switching tabs quickly. It now ensures only the latest result is used, and also adds support for manual cancellation.
Additional context
Replaces #4797 — reopened because the previous branch name conflicted with an existing one, and includes updated test cases and add doc.