Skip to content

perf(usePreferredLanguages): use shallowRef for better performance #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

perf(usePreferredLanguages): use shallowRef for better performance #4973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/core/usePreferredLanguages/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Ref } from 'vue'
import type { ShallowRef } from 'vue'
import type { ConfigurableWindow } from '../_configurable'
import { ref as deepRef } from 'vue'
import { shallowRef } from 'vue'
import { defaultWindow } from '../_configurable'
import { useEventListener } from '../useEventListener'

Expand All @@ -12,13 +12,13 @@ import { useEventListener } from '../useEventListener'
*
* @__NO_SIDE_EFFECTS__
*/
export function usePreferredLanguages(options: ConfigurableWindow = {}): Ref<readonly string[]> {
export function usePreferredLanguages(options: ConfigurableWindow = {}): ShallowRef<readonly string[]> {
const { window = defaultWindow } = options
if (!window)
return deepRef(['en'])
return shallowRef(['en'])

const navigator = window.navigator
const value = deepRef<readonly string[]>(navigator.languages)
const value = shallowRef<readonly string[]>(navigator.languages)

useEventListener(window, 'languagechange', () => {
value.value = navigator.languages
Expand Down