Skip to content

Commit 7c03c7c

Browse files
mikeeemikeee
authored
chore: remove dapr stop steps and add appropriate timeouts (dapr#573)
Signed-off-by: mikeee <hey@mike.ee>
1 parent 4a9f180 commit 7c03c7c

File tree

9 files changed

+16
-38
lines changed

9 files changed

+16
-38
lines changed

‎examples/actor/README.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ expected_stdout_lines:
2121
- '== APP == receive reminder = testReminderName state = "hello" duetime = 5s period = 5s'
2222
background: true
2323
sleep: 30
24+
timeout_seconds: 60
2425
-->
2526

2627
```bash
@@ -54,6 +55,7 @@ expected_stdout_lines:
5455
5556
background: true
5657
sleep: 40
58+
timeout_seconds: 60
5759
-->
5860

5961
```bash
@@ -67,20 +69,11 @@ dapr run --app-id actor-client \
6769

6870
### Cleanup
6971

70-
<!-- STEP
71-
expected_stdout_lines:
72-
- '✅ app stopped successfully: actor-serving'
73-
expected_stderr_lines:
74-
name: Shutdown dapr
75-
-->
76-
7772
```bash
7873
dapr stop --app-id actor-serving
7974
(lsof -i:8080 | grep main) | awk '{print $2}' | xargs kill
8075
```
8176

82-
<!-- END_STEP -->
83-
8477
## Result
8578
- client side
8679
```
@@ -108,4 +101,4 @@ dapr stop --app-id actor-serving
108101
== APP == get req = hello
109102
== APP == receive reminder = testReminderName state = "hello" duetime = 5s period = 5s
110103
== APP == receive reminder = testReminderName state = "hello" duetime = 5s period = 5s
111-
```
104+
```

‎examples/configuration/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ expected_stdout_lines:
2626
- '== APP == dapr configuration subscribe finished.'
2727
background: false
2828
sleep: 40
29+
timeout_seconds: 60
2930
-->
3031

3132
```bash

‎examples/grpc-service/README.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ expected_stdout_lines:
1818
- 'Received: Dapr'
1919
background: true
2020
sleep: 30
21+
timeout_seconds: 60
2122
-->
2223

2324
```bash
@@ -39,6 +40,7 @@ expected_stdout_lines:
3940
output_match_mode: substring
4041
background: true
4142
sleep: 15
43+
timeout_seconds: 60
4244
-->
4345

4446
```bash
@@ -50,15 +52,6 @@ dapr run --app-id grpc-client \
5052

5153
### Cleanup
5254

53-
<!-- STEP
54-
expected_stdout_lines:
55-
- '✅ app stopped successfully: grpc-server'
56-
expected_stderr_lines:
57-
name: Shutdown dapr
58-
-->
59-
6055
```bash
6156
dapr stop --app-id grpc-server
6257
```
63-
64-
<!-- END_STEP -->

‎examples/hello-world/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ There are two ways to launch Dapr applications. You can pass the app executable
8282
name: Run and send order
8383
background: true
8484
sleep: 5
85+
timeout_seconds: 60
8586
expected_stdout_lines:
8687
- '== APP == dapr client initializing for: 127.0.0.1:3500'
8788
- '== APP == Sending order ID 20'
@@ -98,6 +99,7 @@ dapr run --app-id order-app --dapr-grpc-port 3500 --log-level error -- ./order p
9899
name: Run and get order
99100
background: true
100101
sleep: 5
102+
timeout_seconds: 60
101103
expected_stdout_lines:
102104
- '== APP == dapr client initializing for: 127.0.0.1:3500'
103105
- '== APP == Getting order'

‎examples/pubsub/README.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ expected_stdout_lines:
2121
- 'event - PubsubName: messages, Topic: neworder'
2222
background: true
2323
sleep: 15
24+
timeout_seconds: 60
2425
-->
2526

2627
```bash
@@ -43,6 +44,7 @@ expected_stdout_lines:
4344
- '== APP == data published'
4445
background: true
4546
sleep: 15
47+
timeout_seconds: 60
4648
-->
4749

4850
```bash
@@ -58,20 +60,11 @@ dapr run --app-id pub \
5860

5961
### Cleanup
6062

61-
<!-- STEP
62-
expected_stdout_lines:
63-
- '✅ app stopped successfully: sub'
64-
expected_stderr_lines:
65-
name: Shutdown dapr
66-
-->
67-
6863
```bash
6964
dapr stop --app-id sub
7065
(lsof -i:8080 | grep sub) | awk '{print $2}' | xargs kill
7166
```
7267

73-
<!-- END_STEP -->
74-
7568
## Result
7669

7770
```shell

‎examples/service/README.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ expected_stdout_lines:
1717
- "ContentType:text/plain, Verb:POST, QueryString:, hellow"
1818
background: true
1919
sleep: 15
20+
timeout_seconds: 60
2021
-->
2122

2223
```bash
@@ -60,6 +61,7 @@ expected_stdout_lines:
6061
- '== APP == output binding invoked'
6162
background: true
6263
sleep: 15
64+
timeout_seconds: 60
6365
-->
6466

6567
```bash
@@ -155,17 +157,7 @@ Uses the [config/cron.yaml](config/cron.yaml) component
155157

156158
### Cleanup
157159

158-
<!-- STEP
159-
expected_stdout_lines:
160-
- '✅ app stopped successfully: serving'
161-
expected_stderr_lines:
162-
name: Shutdown dapr
163-
-->
164-
165160
```bash
166161
dapr stop --app-id serving
167162
(lsof -i:8080 | grep main) | awk '{print $2}' | xargs kill
168163
```
169-
170-
<!-- END_STEP -->
171-

‎examples/socket/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ There are two ways to launch Dapr applications. You can pass the app executable
7070
name: Run and send order
7171
background: true
7272
sleep: 5
73+
timeout_seconds: 60
7374
expected_stdout_lines:
7475
- '== APP == dapr client initializing for: /tmp/dapr-order-app-grpc.socket'
7576
- '== APP == Sending order ID 20'
@@ -86,6 +87,7 @@ dapr run --app-id order-app --log-level error --unix-domain-socket /tmp -- ./ord
8687
name: Run and get order
8788
background: true
8889
sleep: 5
90+
timeout_seconds: 60
8991
expected_stdout_lines:
9092
- '== APP == dapr client initializing for: /tmp/dapr-order-app-grpc.socket'
9193
- '== APP == Getting order'

‎examples/workflow-parallel/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ expected_stdout_lines:
2323
2424
background: true
2525
sleep: 30
26+
timeout_seconds: 60
2627
-->
2728

2829
```bash

‎examples/workflow/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ expected_stdout_lines:
4040
4141
background: true
4242
sleep: 60
43+
timeout_seconds: 60
4344
-->
4445

4546
```bash

0 commit comments

Comments
 (0)