Fix pytensor overload resolution in pybind11. #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no ideal why CI failed. Could someone have a look? Thank you! |
|
Travis: It looks like conda cannot find cmake on Appveyor: on Windows this seems to be a version conflict of Python, we download last miniconda (i.e 3.7) while the conditions on dependencies are < 3.7 |
|
The root cause of the error on travis is the miniconda distribution we use is too old. |
|
Thanks a lot! I will keep an eye on #205 |
025d1e5 to
2af1f40
Compare
|
Thanks @zhujun98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #178.
@SylvainCorlay I am not sure whether this is a good solution.