fixed CharacterContactListener to include full upstream API #15
+82
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts for FixedConstraintSettings, tweaked casts for TwoBodyConstraintSettings to match ShapeSettings pattern.
|
This looks good to me, nice catch on that. Yea, I think automated validation of the C VTable matching the C++ one would be nice, but I'm not sure what that would look like. I suppose if there was a test that called every method, but that might be tedious. |
kcbanner
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some of the updates of the last few months, the CharacterContactListener struct in JoltPhysicsC.h was not updated to reflect the upstream changes. The mismatch would cause crashes if this type of listener was used.
It should be fixed now, but I do wonder if there aren't more places like this in zphysics which have been a bit left behind. The tests didn't catch this one because the mismatch is between JoltPhysicsC and Jolt proper, but not between zphysics and JoltPhysicsC, and this structure appears to be missing from JoltPhysicsC_Tests.c (probably should fix that too...).