Add build option to disable C++ exceptions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I'm used to the old monorepo, this is a bit confusing, but I surmise that if we merge this, the next step would be to update the monorepo to point to the new commit here, and then, at that point, update I believe this is enough to resolve the duplicate definition issue, since it has appeared to fix it for my own project. However, it might be necessary to also disable exceptions for other 3rd party C++ libraries too in some cases. So once this is merged, I can fix those and make a PR on the monorepo too if you'd like. |
hazeycode
added a commit
to zig-gamedev/zig-gamedev
that referenced
this pull request
Jan 21, 2025
Fixed by zig-gamedev/zphysics#7 Closes #730 Co-authored-by: Galen Cochrane <a-day-old-bagel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to get zphysics building together with zgpu on Windows again by disabling C++ exceptions.
If we can merge this, we might be able to turn on those two samples that stopped working in Windows.