Skip to content

Commit 08cab33

Browse files
DanielleMaywoodDanielleMaywood
committed
refactor: names used
1 parent 5a671e8 commit 08cab33

File tree

9 files changed

+22
-22
lines changed

9 files changed

+22
-22
lines changed

‎coderd/aitasks.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,20 @@ func (api *API) aiTasksCreate(rw http.ResponseWriter, r *http.Request) {
9595
return
9696
}
9797

98-
hasAIPrompt, err := api.Database.GetTemplateVersionHasAIPrompt(ctx, req.TemplateVersionID)
98+
hasAITask, err := api.Database.GetTemplateVersionHasAITask(ctx, req.TemplateVersionID)
9999
if err != nil {
100100
if errors.Is(err, sql.ErrNoRows) || rbac.IsUnauthorizedError(err) {
101101
httpapi.ResourceNotFound(rw)
102102
return
103103
}
104104

105105
httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
106-
Message: "Internal error fetching if template version has ai prompt.",
106+
Message: "Internal error fetching whether the template version has an AI task.",
107107
Detail: err.Error(),
108108
})
109109
return
110110
}
111-
if !hasAIPrompt {
111+
if !hasAITask {
112112
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
113113
Message: `Template does not have required parameter "` + codersdk.AITaskPromptParameterName + `"`,
114114
})

‎coderd/database/dbauthz/dbauthz.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2874,15 +2874,15 @@ func (q *querier) GetTemplateVersionByTemplateIDAndName(ctx context.Context, arg
28742874
return tv, nil
28752875
}
28762876

2877-
func (q *querier) GetTemplateVersionHasAIPrompt(ctx context.Context, id uuid.UUID) (bool, error) {
2877+
func (q *querier) GetTemplateVersionHasAITask(ctx context.Context, id uuid.UUID) (bool, error) {
28782878
// If we can successfully call `GetTemplateVersionByID`, then
28792879
// we know the actor has sufficient permissions to know if the
2880-
// template has an AI Prompt.
2880+
// template has an AI task.
28812881
if _, err := q.GetTemplateVersionByID(ctx, id); err != nil {
28822882
return false, err
28832883
}
28842884

2885-
return q.db.GetTemplateVersionHasAIPrompt(ctx, id)
2885+
return q.db.GetTemplateVersionHasAITask(ctx, id)
28862886
}
28872887

28882888
func (q *querier) GetTemplateVersionParameters(ctx context.Context, templateVersionID uuid.UUID) ([]database.TemplateVersionParameter, error) {

‎coderd/database/dbauthz/dbauthz_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1443,7 +1443,7 @@ func (s *MethodTestSuite) TestTemplate() {
14431443
})
14441444
check.Args(now.Add(-time.Hour)).Asserts(rbac.ResourceTemplate.All(), policy.ActionRead)
14451445
}))
1446-
s.Run("GetTemplateVersionHasAIPrompt", s.Subtest(func(db database.Store, check *expects) {
1446+
s.Run("GetTemplateVersionHasAITask", s.Subtest(func(db database.Store, check *expects) {
14471447
o := dbgen.Organization(s.T(), db, database.Organization{})
14481448
u := dbgen.User(s.T(), db, database.User{})
14491449
t := dbgen.Template(s.T(), db, database.Template{

‎coderd/database/dbmetrics/querymetrics.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/dbmock/dbmock.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/querier.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/queries.sql.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎coderd/database/queries/templateversions.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ WHERE
235235
template_versions.id IN (archived_versions.id)
236236
RETURNING template_versions.id;
237237

238-
-- name: GetTemplateVersionHasAIPrompt :one
238+
-- name: GetTemplateVersionHasAITask :one
239239
SELECT EXISTS (
240240
SELECT 1
241241
FROM template_versions

‎codersdk/aitasks.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ type CreateAITasksRequest struct {
5353
}
5454

5555
func (c *ExperimentalClient) AITasksCreate(ctx context.Context, request CreateAITasksRequest) (Workspace, error) {
56-
res, err := c.Request(ctx, http.MethodPost, "/api/experimental/aitasks/", request)
56+
res, err := c.Request(ctx, http.MethodPost, "/api/experimental/aitasks", request)
5757
if err != nil {
5858
return Workspace{}, err
5959
}

0 commit comments

Comments
 (0)