feat: add multiple API key scopes support with granular permissions #19015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2025
This was referenced Jul 23, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Emyrk
reviewed
Jul 23, 2025
Comment on lines
+177
to
+187
| Site: Permissions(map[string][]policy.Action{ | ||
| ResourceWorkspace.Type: {policy.ActionRead, policy.ActionCreate, policy.ActionUpdate, policy.ActionDelete}, | ||
| }), | ||
| Org: map[string][]Permission{ | ||
| ResourceWorkspace.Type: { | ||
| {ResourceType: ResourceWorkspace.Type, Action: policy.ActionRead}, | ||
| {ResourceType: ResourceWorkspace.Type, Action: policy.ActionCreate}, | ||
| {ResourceType: ResourceWorkspace.Type, Action: policy.ActionUpdate}, | ||
| {ResourceType: ResourceWorkspace.Type, Action: policy.ActionDelete}, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Org level does not make sense in Scope. Just keep it all at the site level.
Remove the org permissions here and the others
Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2c Signed-off-by: Thomas Kosiewski <tk@coder.com>
7d68b72 to
f7d7de0
Compare
99e7a7b to
c2346ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2c
Signed-off-by: Thomas Kosiewski tk@coder.com