-
Notifications
You must be signed in to change notification settings - Fork 962
fix: don't create autostart workspace builds with no available provisioners #19067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cstyan
wants to merge
15
commits into
main
Choose a base branch
from
callum-autostart-no-provisioner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+471
−86
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
314bb66
add test that fails since we still trigger autobuilds even if a
cstyan 310511e
add check for available provisioners before we try to do a workspace
cstyan 1256877
fix provisioner check for tests which don't fully set up/wait for the
cstyan 26f5001
use the runOnce time
cstyan 78a8f5e
refactor: remove SkipProvisionerCheck and improve test provisioner ha…
cstyan a983dc2
more fixes for tests; mostly around ensuring that tests which use the
cstyan 0bc4cce
significantly simplify
cstyan 9a3f534
more refactor and clean up
cstyan a98ef1d
fix lint
cstyan e48c724
hasValidProvisioner only needs tags
cstyan 883c748
more cleanup of function params
cstyan 3c90c6d
already waiting for the workspaces provisioner, don't need to wait for
cstyan 5a6493c
fix print statement missed in earlier commit
cstyan c5f0d41
address more review feedback; mostly around provisioner closers in the
cstyan 224acfc
remove MustWaitForAnyProvisionerWithClient
cstyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.