chore: upgrade to tailwind 4 #19247
Open
chore: upgrade to tailwind 4 #19247
+499
−430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
reviewed
Aug 12, 2025
Comment on lines
+76
to
+77
| window.addEventListener("blur-sm", closeOnTabSwitch); | ||
| return () => window.removeEventListener("blur-sm", closeOnTabSwitch); |
| @@ -496,8 +496,8 @@ export const MultiSelectCombobox = forwardRef< | |||
| <Badge | |||
| key={option.value} | |||
| className={cn( | |||
| "data-[disabled]:bg-content-disabled data-[disabled]:text-surface-tertiarydata-[disabled]:hover:bg-content-disabled", | |||
| "data-[fixed]:bg-content-disabled data-[fixed]:text-surface-tertiary data-[fixed]:hover:bg-surface-secondary", | |||
| "data-disabled:bg-content-disabled data-[disabled]:text-surface-tertiarydata-[disabled]:hover:bg-content-disabled", | |||
There was a problem hiding this comment.
Looks like only some of them got changed. There's also some broken spaces
| @@ -91,7 +91,7 @@ export const Combobox: FC<ComboboxProps> = ({ | |||
| <ChevronDown className="size-icon-sm text-content-secondary group-hover:text-content-primary" /> | |||
| </Button> | |||
| </PopoverTrigger> | |||
| <PopoverContent className="w-[var(--radix-popover-trigger-width)]"> | |||
| <PopoverContent className="w-(--radix-popover-trigger-width)"> | |||
There was a problem hiding this comment.
Does this work? I'm still seeing the var syntax in some of the docs
https://tailwindcss.com/docs/theme#with-arbitrary-values
| @@ -102,7 +102,7 @@ export const SelectContent = React.forwardRef< | |||
| className={cn( | |||
| "p-1", | |||
| position === "popper" && | |||
| "h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)]", | |||
| "h-(--radix-select-trigger-height) w-full min-w-(--radix-select-trigger-width)", | |||
| @@ -54,7 +54,7 @@ const TableFooter = React.forwardRef< | |||
| <tfoot | |||
| ref={ref} | |||
| className={cn( | |||
| "border-t bg-muted/50 font-medium [&>tr]:last:border-b-0", | |||
| "border-t bg-muted/50 font-medium last:[&>tr]:border-b-0", | |||
There was a problem hiding this comment.
I think this is okay, but just making sure: did we test this one?
| @@ -71,7 +71,7 @@ export const useAppLink = ( | |||
| displayError(`${label} must be installed first.`); | |||
| } | |||
| }, openAppExternallyFailedTimeout); | |||
| window.addEventListener("blur", () => { | |||
| window.addEventListener("blur-sm", () => { | |||
| @@ -48,7 +48,7 @@ export const InboxPopover: FC<InboxPopoverProps> = ({ | |||
| <InboxButton unreadCount={unreadCount} /> | |||
| </PopoverTrigger> | |||
| <PopoverContent | |||
| className="w-[var(--radix-popper-available-width)] max-w-[466px]" | |||
| className="w-(--radix-popper-available-width) max-w-[466px]" | |||
| @@ -59,7 +59,7 @@ export const InboxPopover: FC<InboxPopoverProps> = ({ | |||
| className={cn([ | |||
| "[--bottom-offset:48px]", | |||
| "[--max-height:calc(var(--radix-popover-content-available-height)-var(--bottom-offset))]", | |||
| "[&>[data-radix-scroll-area-viewport]]:max-h-[var(--max-height)]", | |||
| "*:data-radix-scroll-area-viewport:max-h-(--max-height)", | |||
There was a problem hiding this comment.
We might be okay, but I'm drawing attention to it, just in case: I don't know if the previous style was valid, since we didn't have the &>*. I'm always skittish about fixing something that was previously broken, and having that ripple out
| @@ -51,7 +51,7 @@ const DeploymentSettingsLayout: FC = () => { | |||
| </BreadcrumbList> | |||
| </Breadcrumb> | |||
| <hr className="h-px border-none bg-border" /> | |||
| <div className="px-10 max-w-screen-2xl"> | |||
| <div className="px-10 max-w-(--breakpoint-2xl)"> | |||
There was a problem hiding this comment.
Surprised that Tailwind doesn't have classes for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the diff is from their upgrade tool doing code-mod stuff.
I think I'm gonna migrate the tailwind.config.js file to CSS config separately just to keep things reviewable and small.