fix: prevent activity bump for prebuilt workspaces #19263
Draft
+37
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Can you check the EXPLAIN output before and after?
| if allowed { | ||
| nextAutostart = next | ||
| // Prebuilds are not subject to activity-based deadline bumps | ||
| if !workspace.IsPrebuild() { |
There was a problem hiding this comment.
suggestion: invert the logic and continue / return early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that activity-based deadline extensions ("activity bumping") are not applied to prebuilt workspaces. Prebuilds are managed by the reconciliation loop and must not have
deadlineormax_deadlinevalues set or extended, as they are not part of the regular lifecycle executor path.Changes
ActivityBumpWorkspaceSQL query to discard prebuilt workspacesRelated with: