Skip to content

feat(coderd): add support for external agents to API's and provisioner #19286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 19, 2025
Merged

feat(coderd): add support for external agents to API's and provisioner #19286

merged 14 commits into from
Aug 19, 2025

Conversation

kacpersaw
Copy link
Contributor

@kacpersaw kacpersaw commented Aug 11, 2025 •
edited
Loading

This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.

Depends on: coder/terraform-provider-coder#424

  • GET /api/v2/init-script - Gets the agent initialization script
    • By default, it returns a script for Linux (amd64), but with query parameters (os and arch) you can get the init script for different platforms
  • GET /api/v2/workspaces/{workspace}/external-agent/{agent}/credentials - Gets credentials for an external agent (enterprise)
  • Updated queries to filter workspaces/templates by the has_external_agent field

@kacpersaw Graphite App
Copy link
Contributor Author

kacpersaw commented Aug 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kacpersaw kacpersaw mentioned this pull request Aug 11, 2025
Merged
This was referenced Aug 11, 2025
Merged
Merged
@kacpersaw kacpersaw changed the title feat: add support for external agents to API's and provisioner feat(coderd): add support for external agents to API's and provisioner Aug 11, 2025
@kacpersaw kacpersaw mentioned this pull request Aug 11, 2025
Closed
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from b641ffe to 07a9c42 Compare August 11, 2025 15:40
@kacpersaw kacpersaw marked this pull request as ready for review August 12, 2025 06:43
@kacpersaw kacpersaw requested a review from deansheather August 12, 2025 06:43
johnstcn
johnstcn approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto changes look fine to me 👍

@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-database branch from c012284 to 63fefbb Compare August 12, 2025 12:44
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 60cccc2 to 0cf5381 Compare August 12, 2025 12:44
deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
@kacpersaw kacpersaw requested a review from aslilac as a code owner August 13, 2025 09:30
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-database branch from 63fefbb to 6033188 Compare August 13, 2025 10:42
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 4e94ed6 to 5a0bf15 Compare August 13, 2025 10:42
@deansheather deansheather self-requested a review August 13, 2025 11:20
deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
coderd/searchquery/search.go
@@ -223,6 +223,7 @@ func Workspaces(ctx context.Context, db database.Store, query string, page coder
Valid: values.Has("outdated"),
}
filter.HasAITask = parser.NullableBoolean(values, sql.NullBool{}, "has-ai-task")
Copy link
Member

@deansheather deansheather Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also file a ticket to fix has-ai-task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19337

deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor additions to my previous comments

@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-database branch from 6033188 to 9e885fe Compare August 13, 2025 12:08
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from 5a0bf15 to ed93d09 Compare August 13, 2025 12:08
deansheather
deansheather reviewed Aug 13, 2025
View reviewed changes
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from bcd7ad2 to c143ef7 Compare August 18, 2025 12:52
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-database branch from 9e885fe to 5a1b1ed Compare August 18, 2025 12:52
@kacpersaw Graphite App
Copy link
Contributor Author

kacpersaw commented Aug 19, 2025 •
edited
Loading

Merge activity

  • Aug 19, 8:29 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 19, 8:31 AM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 19, 8:41 AM UTC: @kacpersaw merged this pull request with Graphite.

@kacpersaw kacpersaw changed the base branch from kacpersaw/feat-coder-attach-database to graphite-base/19286 August 19, 2025 08:29
@kacpersaw kacpersaw changed the base branch from graphite-base/19286 to main August 19, 2025 08:30
kacpersaw added 14 commits August 19, 2025 08:30
@kacpersaw
feat: add support for external agents to API's and provisioner
60dc330
@kacpersaw
generate api model
10fc9fe
@kacpersaw
move /external-agent/{agent}/credentials endpoint to enterprise
5f344a1
@kacpersaw
add Content-Digest header to init script response
28243e3
@kacpersaw
implement license checks for external agents in workspace builds and …
d560e5c 
…templates
@kacpersaw
Update license_test.go
732bc1d
@kacpersaw
Apply review suggestions
5ca172e
@kacpersaw
Add HasExternalAgent to TemplateVersion response
10e6853
@kacpersaw
Update tests
760de9a
@kacpersaw
add HasLicense field to Options and update UsageChecker
3e2288b
@kacpersaw
remove HasLicense field from Options and implement HasLicense method …
ee58237 
…in Entitlements
@kacpersaw
return 404 if external_agent is not associated with agent
b91397d
@kacpersaw
update external agent handling in workspace agents and adjust Terrafo…
fb7bc71 
…rm resource references
@kacpersaw
Remove test
0baf2b3
@kacpersaw kacpersaw force-pushed the kacpersaw/feat-coder-attach-api branch from c143ef7 to 0baf2b3 Compare August 19, 2025 08:30
@kacpersaw kacpersaw merged commit 9edceef into main Aug 19, 2025
35 of 37 checks passed
@kacpersaw kacpersaw deleted the kacpersaw/feat-coder-attach-api branch August 19, 2025 08:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@deansheather deansheather deansheather approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis spikecurtis is a code owner

@aslilac aslilac Awaiting requested review from aslilac aslilac is a code owner

Assignees

@kacpersaw kacpersaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kacpersaw @johnstcn @deansheather