feat(site): add support for external agents in the UI and extend CodeExample #19288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2025
d0f7fd7 to
5ea333a
Compare
1d9ad42 to
2b42673
Compare
5ea333a to
bd266b3
Compare
2b42673 to
039892b
Compare
bd266b3 to
b91a963
Compare
e1fd6e8 to
e7e9376
Compare
b65b376 to
d9d2161
Compare
d36771a to
cec9a8d
Compare
d9d2161 to
2177e0d
Compare
cec9a8d to
ac11687
Compare
2177e0d to
43a2123
Compare
43a2123 to
9a26156
Compare
ac11687 to
515fd53
Compare
f12ed83 to
64b9a7a
Compare
ce5c3e0 to
d5f8141
Compare
64b9a7a to
956e5fb
Compare
aslilac
reviewed
Aug 14, 2025
Comment on lines
26
to
42
| useEffect(() => { | ||
| if ( | ||
| isExternalAgent && | ||
| (agent.status === "timeout" || agent.status === "connecting") | ||
| ) { | ||
| API.getWorkspaceAgentCredentials(workspace.id, agent.name) | ||
| .then((res) => { | ||
| setExternalAgentToken(res.agent_token); | ||
| setCommand(res.command); | ||
| }) | ||
| .catch((err) => { | ||
| displayError( | ||
| getErrorMessage(err, "Failed to get external agent credentials"), | ||
| ); | ||
| }); | ||
| } | ||
| }, [isExternalAgent, agent.status, workspace.id, agent.name]); |
There was a problem hiding this comment.
use useQuery for this. you can look at plenty of examples in the api/queries/ folder.
| ); | ||
| const [command, setCommand] = useState<string | null>(null); | ||
|
|
||
| const origin = isChromatic() ? "https://example.com" : window.location.origin; |
There was a problem hiding this comment.
we should use the deployment config value here instead
const { deploymentConfig } = useDeploymentConfig();
deploymentConfig.config.access_url
| const shouldDisplayAgentApps = | ||
| (agent.status === "connected" && hasAppsToDisplay) || | ||
| agent.status === "connecting"; | ||
| (agent.status === "connecting" && !isExternalAgent); |
There was a problem hiding this comment.
why do we only hide them while connecting?
There was a problem hiding this comment.
I hid the apps when connecting to have a clear view with external agent credentials. The apps would only be installed when the agent is connected, so having them visible doesn’t make sense imo.
bf67f24 to
d67eace
Compare
d5f8141 to
ae3f780
Compare
Merge activity
|
7b3c5d6 to
044076a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.