Skip to content

chore: specify packageManager explicitly to match pinned version in Dockerfile #19311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

chore: specify packageManager explicitly to match pinned version in Dockerfile #19311

merged 2 commits into from
Aug 12, 2025
+2 −1

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Aug 12, 2025 •
edited
Loading

Disclaimer: I have no idea what I'm doing.

It would seem this is necessary since we use corepack in dogfood/coder/Dockerfile.

Without this, I run into:

$ ./scripts/develop.sh --debug --access-url=
generate
+ pnpm install 
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your pnpm version is incompatible with "/home/coder/coder/site".

Expected version: >=9.0.0 <10.0.0
Got: 10.14.0

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".
To check your pnpm version, run "pnpm -v".

Blocked by coder/internal#881 it seems.

@dannykopping dannykopping requested a review from johnstcn August 12, 2025 08:44
@dannykopping dannykopping requested a review from aslilac as a code owner August 12, 2025 08:44
johnstcn
johnstcn approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

aslilac
aslilac reviewed Aug 12, 2025
View reviewed changes
@dannykopping
Specify packageManager explicitly to match pinned version in Dockerfile
7aa422d 
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping
corepack use pnpm@9.15.1
3e2dc9d 
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping dannykopping changed the title Specify packageManager explicitly to match pinned version in Dockerfile chore: specify packageManager explicitly to match pinned version in Dockerfile Aug 12, 2025
@dannykopping dannykopping merged commit 67e1567 into main Aug 12, 2025
34 checks passed
@dannykopping dannykopping deleted the dk/pin-pnpm branch August 12, 2025 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac left review comments

@johnstcn johnstcn johnstcn approved these changes

Assignees

@dannykopping dannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannykopping @aslilac @johnstcn