Update manhattan-distance.md #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transformation \alpha was wrong, because it should just Quote: rotation of the plane followed by a dilation about a center Wrong transformation: (x=1,y=100) -> (x'=101, y'=-99) (wrong transformation is 135 degrees clockwise in this case, not 45), Correct transformation: (x=1,y=100) -> (x'=101, y'=99) Basically, I removed reflection over line x
|
I'm not familiar with this. Thoughts? @Kostero or @adamant-pwn. |
|
It doesn't matter too much, as we still take the absolute value later, but I believe it is a correct fix. |
|
It matters in the sense that in the next paragraph we claim it's a I'll merge this, thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transformation \alpha was wrong, because it should just be a 45-degree rotation of the plane followed by a dilation about a center.
Wrong transformation: (x=1,y=100) -> (x'=101, y'=-99) (wrong transformation is about 135 degrees clockwise in this case, not 45),
Correct transformation: (x=1,y=100) -> (x'=101, y'=99)
Basically, I removed reflection over x-axis.