Skip to content

Update remove_sub_issue tool to use go-github #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tommaso-moro
Copy link
Contributor

Closes: #350

Overview

Now that go-github is on v74, we can use go-github to remove sub issues instead of making raw HTTP requests to the Github API. This PR updates the tool to use go-github

Demo
Screenshot 2025-08-11 at 18 04 24

@tommaso-moro tommaso-moro requested a review from a team as a code owner August 11, 2025 17:07
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 17:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the remove_sub_issue tool from making raw HTTP requests to using the go-github library's native API methods, taking advantage of the recently updated go-github v74 dependency.

  • Replaces manual HTTP request construction with client.SubIssue.Remove() method call
  • Simplifies error handling by leveraging go-github's built-in response handling
  • Removes manual JSON marshaling of request body and response parsing

@tommaso-moro tommaso-moro merged commit cad048b into github:main Aug 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants