add missing database attributes and introduce traits for general attributes #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move properties created_time, last_updated_time, etc. to its own trait - remove attributes and methods from entity classes (which are applied by traid) - apply traid to according entity classes (database, page and block) - add created_by, last_updated_by to this new trait
- refactor rawTitle into richTitle - add description and rawDescription (with according fill and getter)
- within the database entity - add description example to stub
- to ``HasTimestamps`` - for improved readability
…tabase-attributes
- move page logic of ``HasParent`` to its on trait and did minor refactoring - add ``HasParent`` to Database and Block entity
- tests already exist for page entity - add to database and block tests - add raw parent property to stubs within block and database
- add missing prop to stub - add check for property within database test
…5am-code/laravel-notion-api into feature/add-database-attributes
- the handling of archived-flags can be added to entities by this trait - add trait to database, page and block
- to database, block and pages - change stubs regarding the archived-flag, to force testing to check for ``true`` as archived
- and do filling of ``id`` and ``object`` within a entity base class method - call ``::fillEntityBase`` form the ``fillFromRaw`` within all according entitites - add test-cases for checking ``getObjectType``
…5am-code/laravel-notion-api into feature/add-database-attributes
|
- to ``->fillTimestampableAttributes``
…tabase-attributes
- ``...properties`` to ``...attributes``
- move filling of trait related attributes to the context of `fillEssentials()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_inlineattribute toDatabase::classdescriptionattribute toDatabase::classarchived(add to other classes)parent(add to other classesobject(type) toEntity::classfillEntityBase()withinEntity::classfor base filling of general attributes (id,object)--