add url to page #26
Merged
add url to page #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- url is now retreived in the endpoint "->pages()->find($pageId)" - url can now be read by the user in a straightforward way [added to notion-api at 2021-07-02] [https://developers.notion.com/changelog/page-objects-now-return-url]
mechelon
reviewed
Jul 19, 2021
| private function fillUrl(): void | ||
| { | ||
| if (Arr::exists($this->responseData, 'url')) { | ||
| $this->url = $this->responseData['url']; |
There was a problem hiding this comment.
rename to pageUrl? because this is not a property 🤔
- small refactoring was necessary to clarify, that this 'filling' represents the actual page-url of the notion-page and is not a fillable property of a page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[added to notion-api at 2021-07-02]
https://developers.notion.com/changelog/page-objects-now-return-url