Implementations for v0.5.0 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johguentner
commented
Aug 21, 2021
- Added Modifiable contract to set-able properties
- implement notion block types as classes
- add url to page
- implemented tests for blocks-endpoint
- final tweaks and tests
- add easy content and text access for rich-text- (all supported blocks, exept page-blocks) and child-page-blocks - add fromResponse- and mapTypeToClass-method to Block::class (similar to the implementations within Property::class)
Added Shorthand to access all pages possible via search endpoint
check if correct instance is added to collection (depending on block type) check if content of blocks is correctly retreived
- url is now retreived in the endpoint "->pages()->find($pageId)" - url can now be read by the user in a straightforward way [added to notion-api at 2021-07-02] [https://developers.notion.com/changelog/page-objects-now-return-url]
- $value is different for each property - the empty Interface should be sufficient for checking, if the property is modifiable
Modifiable Contract
- small refactoring was necessary to clarify, that this 'filling' represents the actual page-url of the notion-page and is not a fillable property of a page
add url to page
- for HeadingOne, HeadingTwo and HeadingThree
implement notion block types as classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.