Skip to content

fix: check if last_edited_time is a string #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: check if last_edited_time is a string #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Entities/Properties/LastEditedTime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use DateTime;
use Exception;
use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
use Throwable;

/**
* Class LastEditedTime
Expand All @@ -20,10 +21,10 @@ protected function fillFromRaw(): void
parent::fillFromRaw();

try {
if ($this->rawContent !== null) {
if (is_string($this->rawContent) && $this->rawContent !== null) {
$this->content = new DateTime($this->rawContent);
}
} catch (Exception $e) {
} catch (Throwable $e) {
throw HandlingException::instance('The content of last_edited_time is not a valid ISO 8601 date time string.');
}
}
Expand Down