NotionException: Use status from http response #88 additions #95
Conversation
danielh-official
commented
Dec 18, 2022
- add assertions for exception codes
- change the FiveamCode\LaravelNotionApi\Exceptions\NotionException::instance method to use $payload['responseData']['status'] field if it exists in exception code. 0, otherwise.
…ata" array that contains "status" if exists, the status is passed as the code for the NotionException. Otherwise, 0
…sure that http status codes are being passed
|
This reverts commit 44c3cc2.
|
@johguentner Do you need any more testing to be done on this, or is it no longer compatible with the "dev" branch? I noticed there was some movement towards adopting PEST. |
|
@johguentner Also, just a slight nitpick, but I was having trouble getting my PhpStorm to recognize the "Notion" facade. Kept throwing an error wanting to import the full "Notion" class, but if I did that, I would get an error like "$this not used in right context" when running a test. The main suggestion for that issue was using It's not a big deal, but something to keep in mind if you plan to use PhpStorm to develop. |
Thank you @danielh-official for your PR. No prob (since there are no immediate changes necessary for the tests in regards to PEST) ! As long as there is no major stuff in here - which it does not look like - we will polish it and release it with 1.0.0. ✅ |
|
The implementation and all the tests look good! If that's alright with you @mechelon I'll push this into |