Skip to content

Mark PSA as an experimental API #13003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 1, 2020
Merged

Mark PSA as an experimental API #13003

merged 15 commits into from
Jun 1, 2020

Conversation

dgreen-arm
Copy link
Contributor

@dgreen-arm dgreen-arm commented May 21, 2020 •
edited
Loading

Summary of changes

This PR moves PSA to a FEATURE_EXPERIMENTAL_API folder. No change to feature in this folder will be considered breaking, so they can be changed in any release type.

Impact of changes

Migration actions required

The EXPERIMENTAL_API feature will need to be enabled after this PR to enable PSA.

Documentation

The documentation for the experimental api feature is being worked on in ARMmbed/mbed-os-5-docs#1316

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[x] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

I've tested this change by building the crypto getting started example here: https://github.com/ARMmbed/mbed-os-example-mbed-crypto

This example requires PSA and works with these changes once the EXPERIMENTAL_API feature is added. Without it, it fails to build.

At this point I'm not sure which other tests and examples will need updating for this.

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Patater

@mergify mergify bot added the do not merge label May 21, 2020
Patater
Patater previously requested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit "Move TARGET_MBED_PSA_SRV to FEATURE_EXPERIMENTAL_API" needs to also update the Mbed TLS importer, so these files can be imported to their new locations.

@mergify mergify bot added the needs: work label May 21, 2020
@Patater
Copy link
Contributor

Patater commented May 21, 2020

Looks that the paths in .astyleignore also need updating, in the commits that moved the files.

@dgreen-arm dgreen-arm force-pushed the add-feature-experimental branch from 083cf47 to 1064d82 Compare May 21, 2020 14:57
@mergify mergify bot dismissed Patater’s stale review May 21, 2020 14:58

Pull request has been modified.

@ciarmcom ciarmcom requested review from ashok-rao, Patater and a team May 21, 2020 15:00
@ciarmcom
Copy link
Member

@dgreen-arm, thank you for your changes.
@Patater @ashok-rao @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-core @ARMmbed/mbed-os-test @ARMmbed/mbed-os-security @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot removed the needs: review label May 21, 2020
@dgreen-arm dgreen-arm force-pushed the add-feature-experimental branch from 1064d82 to eb4f40d Compare May 26, 2020 08:04
@dgreen-arm dgreen-arm force-pushed the add-feature-experimental branch from eb4f40d to f7ce553 Compare May 26, 2020 14:58
@dgreen-arm
Copy link
Contributor Author

This has been rebased so it's no longer based on #12955. Tests that involve PSA are still expected to fail, this has been pushed so that some review of the folder structure can happen.

Patater
Patater reviewed May 26, 2020
View reviewed changes
@dgreen-arm dgreen-arm force-pushed the add-feature-experimental branch 5 times, most recently from fdec1fb to fc6e7a8 Compare May 27, 2020 12:31
@dgreen-arm dgreen-arm changed the title WIP: Mark PSA as an experimental API Mark PSA as an experimental API May 27, 2020
Patater
Patater previously approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the needs: CI label May 27, 2020
@dgreen-arm dgreen-arm force-pushed the add-feature-experimental branch from e9a4974 to e5f8dd8 Compare May 29, 2020 12:40
@mergify mergify bot dismissed 0xc0170’s stale review May 29, 2020 12:40

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2020 •
edited
Loading

As this is the first experimental feature API, we will gate all under one umbrella correct?

CI started

@dgreen-arm
Copy link
Contributor Author

All experimental features will be gated by the EXPERIMENTAL_API feature, yes. If they're full features in their own right like PSA, they will have their own feature flag that need enabling as well.

@mbed-ci
Copy link

mbed-ci commented May 29, 2020

Test run: FAILED

Summary: 2 of 6 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2020

know error with the client, depends on the fix in the example

@Patater
Copy link
Contributor

Patater commented May 29, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 29, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@mergify mergify bot added needs: CI and removed needs: work labels May 31, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 1, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 7
Build artifacts

@adbridge adbridge merged commit ced3b1c into ARMmbed:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bulislaw bulislaw bulislaw left review comments

@ashok-rao ashok-rao Awaiting requested review from ashok-rao

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dgreen-arm @Patater @ciarmcom @0xc0170 @mbed-ci @bulislaw @adbridge