This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Remove vIRQ_SetVectorX #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API was unused. vIRQ_SetVector is the official way of setting a vIRQ.
|
How do we know it was unused? The code for the removal looks good to me, but I want to make sure we are okay changing the API. |
|
Yes, currently the only use of the vIRQ APIs has been driven by "Just replace NVIC with vIRQ and it works", which means |
|
OK. Will we remove this from uvisor, too? |
|
Yup, see ARMmbed/uvisor@1ce90d2 |
|
Alright. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@meriac
@Patater