fix(component-core): document.currentScript is null on module apps #859
Conversation
There was a problem hiding this comment.
@onhate This looks good and tests out. One thing needed for this to trigger a release of the components-core package by our semantic-release configuration when it is merged is for there to be a commit to components-core following the Conventional Commits standard. Normally it would be the commit with your code, but since you'll be doing this after the fact, I suggest making a small edit in the components-core README.md (such as adding or removing a line break). And for the commit message, this would work: fix(component-core): commit to trigger release
Let me know if what I'm asking for is not clear.
If you're interested, you can find more details about our Conventional Commits and semantic-release setup at: https://github.com/ASU/asu-unity-stack#-git-commit-guidelines
When that commit is in place, ping me and I'll give it one last look and we should be good.
|
thanks @mlsamuelson for the guidance, it should be ok now, right? |
|
@onhate Looks good! I goofed and said "component-core" instead of "components-core" (plural) but I'll fix it on this side so a build gets triggered. My bad. Approved and merged. Thank you! |
Hello, I'm using vite for the development of the new EPO application and I'm facing an issue while using Unity Header component in this line.
asu-unity-stack/packages/components-core/src/core/utils/script-utils.js
Line 5 in ec31e83
It happens because vite uses "module" to transpile/import the scripts in the browser and for that reason
document.currentScriptis nullhttps://developer.mozilla.org/en-US/docs/Web/API/Document/currentScript
I did a quick test here and just checking if it's null first works for me because my application is loading resources from
/which is the fallback for the method.Ideally the application should ignore this piece of logic when passing the logo properties to the component (I see this is only used to resolve the fallback assets for the logo)